araemer/recipe-platform
1
0
Fork 0
Code Issues 13 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Task: move legacy routes to GET reads and shallow nesting #23

New issue
Open
opened 2026-09-30 18:45:21 +00:00 by araemer · 0 comments
araemer commented 2026-09-30 18:45:21 +00:00
Owner
Copy link

Problem

Two new conventions from spec 001 (docs/adr/2026-09-30-get-reads-and-shallow-nesting.md, docs/api-conventions.md) are not yet followed by older routes:

Reads without a request body must use GET. These are POST without a body:

Route File
POST /meal-plan/list api-contract/src/meal-plans.ts
POST /passkey/list api-contract/src/passkeys.ts

At most one id per path (shallow nesting). These carry two ids, or identify a child by an id in the body under the parent's path:

Route File
DELETE /recipe/:id/images/:imageId api-contract/src/recipes.ts
DELETE /meal-plan/:id/day/:dayId api-contract/src/meal-plans.ts
DELETE /meal-plan/:id/share/:shareId api-contract/src/meal-plans.ts
POST /meal-plan/:id/day/save-or-update (update case: day id in body) api-contract/src/meal-plans.ts
POST /meal-plan/:id/share/save-or-update (update case: share id in body) api-contract/src/meal-plans.ts

Fix

Move each route to the new form when its domain is next touched, e.g. GET /meal-plan/all, DELETE /meal-plan-day/:dayId, POST /meal-plan/:id/add-day plus POST /meal-plan-day/:dayId/<verb>. Contract change affecting recipe-backend and recipe-app; the meal plan share routes can go together with recipe-app#46.

Found during the cross-cutting architecture review of spec 001 (PR #20).

## Problem Two new conventions from spec 001 (`docs/adr/2026-09-30-get-reads-and-shallow-nesting.md`, `docs/api-conventions.md`) are not yet followed by older routes: **Reads without a request body must use GET.** These are POST without a body: | Route | File | |---|---| | `POST /meal-plan/list` | `api-contract/src/meal-plans.ts` | | `POST /passkey/list` | `api-contract/src/passkeys.ts` | **At most one id per path (shallow nesting).** These carry two ids, or identify a child by an id in the body under the parent's path: | Route | File | |---|---| | `DELETE /recipe/:id/images/:imageId` | `api-contract/src/recipes.ts` | | `DELETE /meal-plan/:id/day/:dayId` | `api-contract/src/meal-plans.ts` | | `DELETE /meal-plan/:id/share/:shareId` | `api-contract/src/meal-plans.ts` | | `POST /meal-plan/:id/day/save-or-update` (update case: day id in body) | `api-contract/src/meal-plans.ts` | | `POST /meal-plan/:id/share/save-or-update` (update case: share id in body) | `api-contract/src/meal-plans.ts` | ## Fix Move each route to the new form when its domain is next touched, e.g. `GET /meal-plan/all`, `DELETE /meal-plan-day/:dayId`, `POST /meal-plan/:id/add-day` plus `POST /meal-plan-day/:dayId/<verb>`. Contract change affecting recipe-backend and recipe-app; the meal plan share routes can go together with recipe-app#46. Found during the cross-cutting architecture review of spec 001 (PR #20).
araemer changed title from Contract: move legacy routes to GET reads and shallow nesting to Task: move legacy routes to GET reads and shallow nesting 2026-10-02 20:08:28 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
004-fill-list-from-meal-plan-status
004-fill-list-from-meal-plan-gate-b
004-fill-list-from-meal-plan-contract
004-fill-list-from-meal-plan
team-definition
release-pr-gate
003-compact-user-in-embedded-dtos-contract
003-compact-user-in-embedded-dtos-status
003-compact-user-in-embedded-dtos
002-shopping-list-overview-previews-status
002-shopping-list-overview-previews-card-layout
contract-pin
002-shopping-list-overview-previews
plan-feature-branches
001-shopping-lists
epic-layer
release-script
workflow-review-fixes
shared-workflow-plugin
build-contract-for-node
add-pr-feedback-skill
fix-image-route-path-pattern
fix-contract-mandatory-fields
add-consent-rule
sibling-repo-work-via-subagent
fix-contract-ci-install-step
fix-contract-ci-clone-mechanism
fix-recipes-contract-unused-import
fix-skill-format
bootstrap-orchestration-repo
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
araemer/recipe-platform#23
No description provided.