araemer/recipe-backend
1
0
Fork 0
Code Issues 4 Pull requests 2 Projects Releases 17 Packages Wiki Activity Actions

Task: Run the database-backed integration tests in CI #28

New issue
Open
opened 2026-10-03 17:38:04 +00:00 by araemer · 0 comments
araemer commented 2026-10-03 17:38:04 +00:00
Owner
Copy link

Spec 002 adds database-backed integration tests (npm run test:integration, files named *.integration.test.ts). They need a real PostgreSQL. The PR check runs on a runner without a database available to the pipeline, so these tests only run when someone runs them by hand.

Why it matters

They are the only tests that catch a wrong lock order in the shopping list item writes (the "change row is written last" rule) and errors in the hand-written overview queries. Unit tests mock the repositories and cannot see either. A test that only runs by hand gets skipped, and a later change to the item writes can then break the rule unnoticed.

Options

  • PostgreSQL as a service container in pr_check.yaml. Needs Docker on the runner (the Raspberry Pi).
  • A dedicated test database on the existing PostgreSQL, with its connection settings as pipeline secrets. The test setup already creates and drops its own schema per run, so parallel or repeated runs do not interfere.

Done when

  • pr_check.yaml runs npm run test:integration and fails the check when it fails.
  • CLAUDE.md and docs/architecture.md no longer say the integration tests are outside CI.

Context

Left open in the spec 002 backend plan (docs/plans/002-shopping-list-overview-previews.md, judgment call 1). It is a decision about the runner setup, not about the feature.

Spec 002 adds database-backed integration tests (`npm run test:integration`, files named `*.integration.test.ts`). They need a real PostgreSQL. The PR check runs on a runner without a database available to the pipeline, so these tests only run when someone runs them by hand. ## Why it matters They are the only tests that catch a wrong lock order in the shopping list item writes (the "change row is written last" rule) and errors in the hand-written overview queries. Unit tests mock the repositories and cannot see either. A test that only runs by hand gets skipped, and a later change to the item writes can then break the rule unnoticed. ## Options - **PostgreSQL as a service container in `pr_check.yaml`.** Needs Docker on the runner (the Raspberry Pi). - **A dedicated test database on the existing PostgreSQL**, with its connection settings as pipeline secrets. The test setup already creates and drops its own schema per run, so parallel or repeated runs do not interfere. ## Done when - `pr_check.yaml` runs `npm run test:integration` and fails the check when it fails. - `CLAUDE.md` and `docs/architecture.md` no longer say the integration tests are outside CI. ## Context Left open in the spec 002 backend plan (`docs/plans/002-shopping-list-overview-previews.md`, judgment call 1). It is a decision about the runner setup, not about the feature.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
stage
timestamptz-create-update-date
004-fill-list-from-meal-plan
team-definition
main
003-compact-user-in-embedded-dtos
002-shopping-list-overview-previews
contract-pin-check
contract-pin
fix-optimistic-lock-race
001-shopping-lists
push-every-commit
fix-plugin-marketplace-url
shared-workflow-plugin
fix-contract-packaging-rm
ship-built-contract
add-pr-feedback-skill
onboard-recipe-platform-contract
docs-git-workflow
passkey-auth
recipe-owner-filter
compact-recipe-amount
meal-plan-dish-amount-description
add-vitest
meal-plan
health-endpoint
ai-recipe-import
resources
refreshToken
rating
applicationService
uuids
comments
tags
v2.2.2
v2.2.1
v2.2.0
v2.1.0
v1.8.0
v1.7.1
v1.7.0
v1.6.0
v1.5.1
v1.5.0
v1.4.0
V1.4.0
v1.3.1
v1.3.0
v1.2.0
v1.1.0
v1.0.1
v0.0.3
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
araemer/recipe-backend#28
No description provided.