docs and background for details page

This commit is contained in:
Anika Raemer 2025-10-12 20:09:00 +02:00
parent 3f075d509b
commit ef8388be6d
5 changed files with 123 additions and 106 deletions

View file

@ -10,6 +10,10 @@
@apply flex items-center w-screen justify-center min-h-screen bg-gray-50;
}
.content-container {
@apply bg-gray-100 w-full min-h-screen max-w-6xl shadow-xl p-8
}
/* headings */
.content-title{
@apply text-3xl font-black mb-8 text-blue-900;
@ -61,7 +65,6 @@
.dark-button-text{
@apply text-white;
}
.transparent-button-bg {
@apply bg-transparent hover:bg-transparent;
}
@ -71,7 +74,7 @@
/* input fields like input and textarea */
.input-field {
@apply p-2 w-full border rounded-md placeholder-gray-400 border-gray-600 hover:border-blue-800 transition-colors text-gray-600 focus:outline-none focus:border-blue-900;
@apply p-2 w-full border rounded-md bg-white placeholder-gray-400 border-gray-600 hover:border-blue-800 transition-colors text-gray-600 focus:outline-none focus:border-blue-900;
}
/* groups */

View file

@ -1,5 +1,8 @@
import type { LucideIcon } from "lucide-react";
/**
* Basic definitions used by all Button types, such as Button.tsx and ButtonLink.tsx
*/
export type BasicButtonProps = {
/** Optional Lucide icon (e.g. Plus, X, Check) */
icon?: LucideIcon;
@ -15,20 +18,20 @@ export type BasicButtonProps = {
*/
export const ButtonType = {
DarkButton: {
textColor: "text-dark-button-text",
backgroundColor: "bg-dark-button-bg",
textColor: "dark-button-text",
backgroundColor: "dark-button-bg",
},
PrimaryButton: {
textColor: "text-primary-button-text",
backgroundColor: "bg-primary-button-bg",
textColor: "primary-button-text",
backgroundColor: "primary-button-bg",
},
DefaultButton: {
textColor: "text-default-button-text",
backgroundColor: "bg-default-button-bg",
textColor: "default-button-text",
backgroundColor: "default-button-bg",
},
TransparentButton: {
textColor: "text-transparent-button-text",
backgroundColor: "bg-transparent-button-bg",
textColor: "transparent-button-text",
backgroundColor: "transparent-button-bg",
},
} as const;

View file

@ -5,6 +5,9 @@ type ButtonProps = BasicButtonProps & {
onClick: () => void;
};
/**
* Button component. Styles are defined in BasicButtonDefinitions.ts
*/
export default function Button({
onClick,
icon: Icon,
@ -15,7 +18,7 @@ export default function Button({
}: ButtonProps) {
return (
<button
className={`basic-button ${buttonType.backgroundColor} ${buttonType.textColor} ${className}`}
className={`basic-button bg-primary-button-bg ${buttonType.backgroundColor} ${buttonType.textColor} ${className}`}
onClick={onClick}
{...props}
>

View file

@ -17,32 +17,32 @@ export default function RecipeDetailPage() {
// the recipe loaded from the backend, don't change this! it's required for scaling
const [recipe, setRecipe] = useState<RecipeModel | null>(null)
// Working copy for re-calculating ingredients
const [recipeWorkingCopy, setRecipeWorkingCopy] = useState<RecipeModel|null>(null)
const [recipeWorkingCopy, setRecipeWorkingCopy] = useState<RecipeModel | null>(null)
// load recipe data whenever id changes
useEffect(() => {
const loadRecipe = async () => {
if (id) {
try {
// Fetch recipe data when editing an existing one
console.log("loading recipe with id", id)
const data = await fetchRecipe(id)
if(data.id != id){
throw new Error("Id mismatch when loading recipes: " + id + " requested and " + data.id + " received!");
}
setRecipe(mapRecipeDtoToModel(data))
} catch (err) {
console.error(err)
useEffect(() => {
const loadRecipe = async () => {
if (id) {
try {
// Fetch recipe data when editing an existing one
console.log("loading recipe with id", id)
const data = await fetchRecipe(id)
if (data.id != id) {
throw new Error("Id mismatch when loading recipes: " + id + " requested and " + data.id + " received!");
}
setRecipe(mapRecipeDtoToModel(data))
} catch (err) {
console.error(err)
}
}
}
loadRecipe()
}, [id])
loadRecipe()
}, [id])
// set original recipe data and working copy when recipe changes
useEffect( ()=> {
setRecipeWorkingCopy(recipe);
}, [recipe])
// set original recipe data and working copy when recipe changes
useEffect(() => {
setRecipeWorkingCopy(recipe);
}, [recipe])
if (!recipe || !recipeWorkingCopy) {
@ -50,7 +50,7 @@ export default function RecipeDetailPage() {
}
/** recalculate ingredients based on the amount of servings */
/** recalculate ingredients based on the amount of servings */
const recalculateIngredients = (newAmount: number) => {
// Always calculate factor from the *original recipe*, not the working copy
const factor = newAmount / recipe.servings.amount
@ -76,81 +76,89 @@ export default function RecipeDetailPage() {
}
return (
<div className="p-6 max-w-2xl mx-auto">
<h1 className="content-title">{recipeWorkingCopy.title}</h1>
{/* Recipe image */}
{recipe.imageUrl && (
<img
src={recipe.imageUrl}
alt={recipe.title}
className="w-full rounded-xl mb-4 border"
/>
)}
{/* Servings */}
<div className="flex flex-row items-center gap-2 bg-blue-100 columns-2 rounded p-2 mb-4">
<p className="mb-2">For {recipeWorkingCopy.servings.amount} {recipeWorkingCopy.servings.unit}</p>
<input
type="number"
className="input-field w-20 ml-auto"
value={recipeWorkingCopy.servings.amount}
onChange={
e => {
recalculateIngredients(Number(e.target.value))
}
}
/>
/*Container spanning entire screen used to center content horizontally */
<div className="app-bg">
{/* Container defining the maximum width of the content */}
<div className="content-container">
{/* Header - remains in position when scrolling */}
<div className="sticky bg-gray-100 top-0 left-0 right-0 pb-4 border-b-2 border-gray-300">
<h1 className="content-title">{recipeWorkingCopy.title}</h1>
</div>
{/* Ingredients */}
<h2 className="section-heading">Zutaten</h2>
<ul>
{recipeWorkingCopy.ingredientGroupList.map((group,i) => (
<div key={i}>
{/* the title is optional, only print if present */}
{group.title && group.title.trim() !== "" && (
<h3 className="subsection-heading">{group.title}</h3>
)}
<ul className="default-list">
{group.ingredientList.map((ing, j) => (
<li key={j}>
{ing.amount} {ing.unit ?? ""} {ing.name}
</li>
))}
</ul>
<div className="p-6 max-w-2xl mx-auto">
{/* Recipe image */}
{recipe.imageUrl && (
<img
src={recipe.imageUrl}
alt={recipe.title}
className="w-full rounded-xl mb-4 border"
/>
)}
{/* Servings */}
<div className="flex flex-row items-center gap-2 bg-blue-100 columns-2 rounded p-2 mb-4">
<p className="mb-2">For {recipeWorkingCopy.servings.amount} {recipeWorkingCopy.servings.unit}</p>
<input
type="number"
className="input-field w-20 ml-auto"
value={recipeWorkingCopy.servings.amount}
onChange={
e => {
recalculateIngredients(Number(e.target.value))
}
}
/>
</div>
))}
</ul>
{/* Instructions - @todo add reasonable list delegate component*/}
<ol className="space-y-4">
{recipe.instructionStepList.map((step, j) => (
<li key={j} className="flex items-start gap-4">
{/* Step number circle */}
<div className="enumeration-indicator">
{j + 1}
{/* Ingredients */}
<h2 className="section-heading">Zutaten</h2>
<ul>
{recipeWorkingCopy.ingredientGroupList.map((group, i) => (
<div key={i}>
{/* the title is optional, only print if present */}
{group.title && group.title.trim() !== "" && (
<h3 className="subsection-heading">{group.title}</h3>
)}
<ul className="default-list">
{group.ingredientList.map((ing, j) => (
<li key={j}>
{ing.amount} {ing.unit ?? ""} {ing.name}
</li>
))}
</ul>
</div>
))}
</ul>
{/* Step text */}
<p className="leading-relaxed">{step.text}</p>
</li>
))}
</ol>
{/* Instructions - @todo add reasonable list delegate component*/}
<ol className="space-y-4">
{recipe.instructionStepList.map((step, j) => (
<li key={j} className="flex items-start gap-4">
{/* Step number circle */}
<div className="enumeration-indicator">
{j + 1}
</div>
{/* Action buttons */}
<div className="button-group">
<ButtonLink
to={recipe.id !== undefined ? getRecipeEditUrl(recipe.id) : getRecipeListUrl()} // @todo show error instead
className="basic-button primary-button-bg primary-button-text"
text="Bearbeiten"
/>
<ButtonLink
to={getRecipeListUrl()}
className="basic-button default-button-bg default-button-text"
text="Zurueck"
/>
{/* Step text */}
<p className="leading-relaxed">{step.text}</p>
</li>
))}
</ol>
{/* Action buttons */}
<div className="button-group">
<ButtonLink
to={recipe.id !== undefined ? getRecipeEditUrl(recipe.id) : getRecipeListUrl()} // @todo show error instead
className="basic-button primary-button-bg primary-button-text"
text="Bearbeiten"
/>
<ButtonLink
to={getRecipeListUrl()}
className="basic-button default-button-bg default-button-text"
text="Zurueck"
/>
</div>
</div>
</div>
</div>
)
}

View file

@ -41,7 +41,7 @@ export default function RecipeListPage() {
/*Container spanning entire screen used to center content horizontally */
<div className="app-bg">
{/* Container defining the maximum width of the content */}
<div className="bg-gray-100 w-full min-h-screen max-w-6xl shadow-xl p-8">
<div className="content-container">
{/* Header - remains in position when scrolling */}
<div className="sticky bg-gray-100 top-0 left-0 right-0 pb-4 border-b-2 border-gray-300">
<h1 className="content-title">Recipes</h1>